fix: allowed LatLngBounds.center to work across world boundary & added simpleCenter
#1860
Conversation
Impacted files: * `latlng_bounds.dart`: fixed the computation of `center` according to referenced link; added a more intuitive `simpleCenter` method. * `latlng_bounds_test.dart`: added the tests that failed in the initial issue
JaffaKetchup
requested review from
josxha,
mootw,
TesteurManiak,
JaffaKetchup and
ibrierley
|
@josxha Did you have any other concerns about this? One thing maybe we should consider is writing a small doc snippet to compare them and which is better for what situation. |
There was a problem hiding this comment.
LGTM, although maybe a little bit of better documentation would be good? Maybe a diagram of where the two centers would calculate different values, and which is correct to use for which situation?
Will wait for @josxha to approve before merge.
JaffaKetchup
changed the title
LatLngBounds.center and added simpleCenterLatLngBounds.center to work across world boundary & added simpleCenter
|
The changes in this pull request are straight forward. The only two things I struggle with are the name |
|
Regarding the naming: in the original code transformed here into dart, the description of the "complex" center is
|
What
LatLngBounds.centermentioned a [-180, +180] fix - now that fix is implemented.LatLngBounds.simpleCenteris now implemented.Impacted files
latlng_bounds.dart: fixed the computation ofcenteraccording to referenced link; added a more intuitivesimpleCentermethod.latlng_bounds_test.dart: added the tests that failed in the initial issue